Conversation
xgboost's Python package is a scikit-build-core project whose CMakeLists builds libxgboost.so from the sibling C++ tree and installs it into xgboost/lib. `wheel.py-api = "py3"` makes that a single py3-none-<plat> wheel, so the port is upstream's macOS cibuildwheel job (ops/pipeline/build-python-wheels-macos.sh) narrowed to manylinux_riscv64, with one deviation: - upstream's committed pyproject.toml is the CUDA variant and requires nvidia-nccl-cu13 on Linux, which does not exist for riscv64. The workflow regenerates it with `ops/script/pypi_variants.py --use-suffix=na --require-nccl-dep=na`, which is the NCCL-free `xgboost` upstream already publishes for macOS and win_arm64. Tests are upstream's `cpu-arm64` suite from ops/pipeline/test-python-wheel.sh, unchanged. scikit-learn is compiled in-container rather than dropped: xgboost.testing importorskips sklearn.datasets at module level, so without it every test module skips wholesale and the run proves nothing. numpy/scipy/pandas come from the registry as wheels via PIP_ONLY_BINARY, scoped to the test phase. The wheel vendors the image's libgomp.so.1 (auditwheel), hence the gpl_sources job. Validated on aarch64 in the same Rocky 10 manylinux image family: the wheel builds in 14m CPU, carries xgboost/lib/libxgboost.so plus xgboost.libs/libgomp-*.so.1.0.0 and dist-info/licenses/LICENSE, and the suite passes 34/34 against a cibuildwheel-shaped staged test cwd. A cmake configure under linux/riscv64 in manylinux_2_39_riscv64 succeeds (gcc 14.3.1, OpenMP 4.5, SSE2 correctly not selected). Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
Depends on scikit-learn |
luhenry
marked this pull request as draft
August 26, 2026 12:24
Member
Author
|
Confirmed, but it is a sequencing note rather than a blocker: this run is green today with scikit-learn compiled from sdist in-container (~22 min of the 63 min job), and the port is not waiting on anything.
|
luhenry
marked this pull request as ready for review
August 27, 2026 00:18
luhenry
marked this pull request as draft
August 27, 2026 00:35
scikit-learn was deliberately absent from PIP_ONLY_BINARY because no riscv64 wheel existed, so pip fell back to its sdist and spent about 22 minutes of a 63 minute job compiling it in-container. #339 is merged and publishing 1.9.0, which is the version pip resolves to here, so adding it to the list forces the registry wheel and removes that compile. The test phase will fail until the publish lands: with scikit-learn in PIP_ONLY_BINARY there is no sdist fallback left, and xgboost.testing importorskips sklearn.datasets at module level, so the suite needs it.
luhenry
marked this pull request as ready for review
August 28, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xgboost3.4.1scikit-build-core project compiling the sibling C++ tree into
libxgboost.so, loaded through ctypes. Upstream publishespy3-none-manylinuxwheels for x86_64 and aarch64 only.Mirrors upstream's
python_wheels_manylinux.yml.Differs from upstream
ops/script/pypi_variants.py --use-suffix=na --require-nccl-dep=narun before the build — the committedpyproject.tomlis the CUDA variant and declaresnvidia-nccl-cu13, which has no riscv64 wheel. This is upstream's own generator, producing the metadata they already ship for macOS and win_arm64.PIP_EXTRA_INDEX_URLadded for numpy, scipy, pandas and scikit-learn.Matrix: one
py3-nonewheel —wheel.py-api = "py3", no CPython ABI involved.Testing
License: ✅ Wheel ships
dist-info/licenses/LICENSE(Apache-2.0). auditwheel bundles the image's libgomp, so agpl_sourcesjob publishes gcc sources against the same pinned image.34 passed.
build_info()reportsUSE_OPENMP: True, USE_CUDA: False, USE_NCCL: False.